qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: C++ Broker: fix to allow deletion of federation links regardless of connection state.
Date Wed, 23 Jan 2013 22:34:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9055/#review15626
-----------------------------------------------------------


Looks good, but I still don't see where the problem would be with HA on 0.18.


/trunk/qpid/cpp/src/qpid/broker/Link.cpp
<https://reviews.apache.org/r/9055/#comment33720>

    what if we get a closed call while !STATE_CLOSING? Don't we still want to destroy?



/trunk/qpid/cpp/src/qpid/broker/Link.cpp
<https://reviews.apache.org/r/9055/#comment33722>

    Style: should be destroyNow
    



/trunk/qpid/cpp/src/qpid/broker/Link.cpp
<https://reviews.apache.org/r/9055/#comment33721>

    Style: should be oldState


- Alan Conway


On Jan. 22, 2013, 9:10 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9055/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 9:10 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Ted Ross.
> 
> 
> Description
> -------
> 
> Fixes a bug that prevents deletion of a Link when the corresponding connection is not
in the active state.
> 
> 
> This addresses bug qpid-4546.
>     https://issues.apache.org/jira/browse/qpid-4546
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/Link.h 1436517 
>   /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1436517 
>   /trunk/qpid/cpp/src/tests/CMakeLists.txt 1436517 
> 
> Diff: https://reviews.apache.org/r/9055/diff/
> 
> 
> Testing
> -------
> 
> Federation unit tests + tested deleting links that were disconnected and in connection
state.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message