qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Review Request: part 3 of gcc flags for C++ compatibility
Date Thu, 24 Jan 2013 08:30:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9086/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.


Description
-------

gcc flag "-sign-compare" that provides c++ checking


This addresses bug proton-159.
    https://issues.apache.org/jira/browse/proton-159


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/buffer.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/posix/driver.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c 1435762 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c 1435762 

Diff: https://reviews.apache.org/r/9086/diff/


Testing
-------

compiles on linux and runs proton test.  Along with other patches, also compiles in Visual
Studio.


Thanks,

Cliff Jansen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message