qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Review Request: part5 changes for g++
Date Mon, 28 Jan 2013 19:59:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9124/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.


Description
-------

Changes for C++ not handled by other flags.  Basically:

inttypes.h issues
aggregate assignment
late declaration of auto vars in the middle of a switch statement
explicit casts of void* to xyz*
minor const fussiness

Note that the next step to VC++ on Windows has no additional language syntax issues.  It is
all about missing C99 headers and library support.


This addresses bug proton-159.
    https://issues.apache.org/jira/browse/proton-159


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/CMakeLists.txt
1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/python.i 1439550

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/CMakeLists.txt
1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h 1439550

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h 1439550

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/message/message.c 1439550

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform_fmt.h PRE-CREATION

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/scanner.c 1439550 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/types.c 1439550 

Diff: https://reviews.apache.org/r/9124/diff/


Testing
-------

This compiles and runs, but only if you stitch the previous 4 related patches together.  It
does not work standalone.


Thanks,

Cliff Jansen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message