qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Review Request: QPID-4555: Fix handling of no-credit consumers in Queue::getNextMessage.
Date Thu, 31 Jan 2013 16:40:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9183/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Description
-------

QPID-4555: Fix handling of no-credit consumers in Queue::getNextMessage.

This was discovered while investigating QPID-4555 but could affect any consumer
using bounded credt.


Diffs
-----

  /trunk/qpid/cpp/examples/messaging/CMakeLists.txt 1439431 
  /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.h 1439431 
  /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/broker/Connection.h 1439431 
  /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/broker/Consumer.h 1440778 
  /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1440778 
  /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1439431 
  /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.h 1439431 
  /trunk/qpid/cpp/src/qpid/messaging/amqp/TcpTransport.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/AggregateOutput.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/AggregateOutput.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/sys/AsynchIO.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/OutputControl.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/RdmaIOPlugin.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.cpp 1439431 
  /trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.h 1439431 
  /trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.cpp 1439431 
  /trunk/qpid/java/.gitignore 1439431 
  /trunk/qpid/java/perftests/etc/perftests-jndi.properties 1439431 
  /trunk/qpid/java/perftests/etc/run-perftests.sh PRE-CREATION 
  /trunk/qpid/java/perftests/etc/visualisation.sh PRE-CREATION 
  /trunk/qpid/java/perftests/example/perftests-jndi.properties 1439431 
  /trunk/qpid/java/perftests/example/run.sh 1439431 
  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/ArgumentParser.java 1439431

  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/ControllerRunner.java
1439431 
  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/client/ConsumerParticipant.java
1439431 
  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/db/ResultsDbWriter.java
PRE-CREATION 
  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/message/ConsumerParticipantResult.java
1439431 
  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/message/ParticipantResult.java
1439431 
  /trunk/qpid/java/perftests/src/main/java/org/apache/qpid/disttest/message/ProducerParticipantResult.java
1439431 
  /trunk/qpid/java/perftests/src/test/java/org/apache/qpid/disttest/db/ResultsDbWriterTest.java
PRE-CREATION 
  /trunk/qpid/java/perftests/src/test/java/org/apache/qpid/disttest/results/ResultsTestFixture.java
PRE-CREATION 
  /trunk/qpid/java/perftests/src/test/java/org/apache/qpid/disttest/results/formatting/CSVFormatterTest.java
1439431 
  /trunk/qpid/java/perftests/src/test/java/org/apache/qpid/systest/disttest/endtoend/EndToEndTest.java
1439431 
  /trunk/qpid/java/perftests/src/test/java/org/apache/qpid/systest/disttest/perftests.systests.properties
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/ChartingUtil.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/chartbuilder/CategoryDataSetBasedChartBuilder.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/chartbuilder/StatisticalBarCharBuilder.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/chartbuilder/XYDataSetBasedChartBuilder.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/seriesbuilder/JdbcCsvSeriesBuilder.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/seriesbuilder/JdbcSeriesBuilder.java
PRE-CREATION 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/seriesbuilder/SeriesBuilder.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/seriesbuilder/SeriesBuilderCallback.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/seriesbuilder/SeriesRow.java
PRE-CREATION 
  /trunk/qpid/java/perftests/visualisation-jfc/src/main/java/org/apache/qpid/disttest/charting/writer/ChartWriter.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/test/java/org/apache/qpid/disttest/charting/chartbuilder/ChartProductionTest.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/test/java/org/apache/qpid/disttest/charting/seriesbuilder/JdbcCsvSeriesBuilderTest.java
1439431 
  /trunk/qpid/java/perftests/visualisation-jfc/src/test/java/org/apache/qpid/disttest/charting/seriesbuilder/JdbcSeriesBuilderTest.java
PRE-CREATION 
  /trunk/qpid/java/perftests/visualisation-jfc/src/test/java/org/apache/qpid/disttest/charting/seriesbuilder/SeriesRowTest.java
PRE-CREATION 
  /trunk/qpid/tools/src/py/qpid-cluster 1439431 
  /trunk/qpid/tools/src/py/qpid-config 1439431 
  /trunk/qpid/tools/src/py/qpid-ha 1439431 
  /trunk/qpid/tools/src/py/qpid-printevents 1439431 
  /trunk/qpid/tools/src/py/qpid-queue-stats 1439431 
  /trunk/qpid/tools/src/py/qpid-route 1439431 
  /trunk/qpid/tools/src/py/qpid-stat 1439431 

Diff: https://reviews.apache.org/r/9183/diff/


Testing
-------


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message