qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request: QPID-4555: Fix handling of no-credit consumers in Queue::getNextMessage.
Date Fri, 01 Feb 2013 08:46:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9183/#review15995
-----------------------------------------------------------

Ship it!


Looks good,thanks for fixing this Alan!

- Gordon Sim


On Jan. 31, 2013, 9:39 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9183/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 9:39 p.m.)
> 
> 
> Review request for qpid and Gordon Sim.
> 
> 
> Description
> -------
> 
> QPID-4555: Fix handling of no-credit consumers in Queue::getNextMessage.
> 
> This was discovered while investigating QPID-4555 but could affect any consumer
> using bounded credt.
> 
> git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1441163 13f79535-47bb-0310-9956-ffa450edef68
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/Consumer.h 1441162 
>   /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1441162 
> 
> Diff: https://reviews.apache.org/r/9183/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message