qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-4555: HA Add declaredExclusive management property to Queues
Date Fri, 01 Feb 2013 22:11:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9258/
-----------------------------------------------------------

(Updated Feb. 1, 2013, 10:11 p.m.)


Review request for qpid, Gordon Sim and Ted Ross.


Description
-------

QPID-4555: HA Add declaredExclusive management property to Queues

The "exclusive" management property can change over the lifetime of a queue.
This creates race conditions where primary and backup disagree over whether a
queue is replicated. To resolve this, added a new management property
"declaredExclusive" which is set when the queue is created and not modified.

Do we need to co-ordinate with the Java build over this change to the schema?


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1441163 
  /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1441163 
  /trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1441163 
  /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1441163 
  /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1441163 
  /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1441163 
  /trunk/qpid/cpp/src/qpid/ha/ReplicationTest.cpp 1441163 
  /trunk/qpid/cpp/src/tests/ha_tests.py 1441163 
  /trunk/qpid/specs/management-schema.xml 1441163 

Diff: https://reviews.apache.org/r/9258/diff/


Testing (updated)
-------

make check
ha tests running 2  hours now without failure.


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message