qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Re: Review Request: symbol import/export
Date Tue, 05 Feb 2013 02:33:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9299/
-----------------------------------------------------------

(Updated Feb. 5, 2013, 2:33 a.m.)


Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.


Changes
-------

Clarified "the first half ..." refers to import_export.h


Description (updated)
-------

Changes for specifying symbol import/export needed for Visual Studio.

Copied with minor variances from the qpid/cpp tree.  The first half of import_export.h is
generic, the second half specific to the qpid-proton library.

If in future, additional libraries come into existence, this include file can be split (or
perhaps expanded), without requiring any changes to files outside of proton-c/include/proton.


This addresses bug proton-68.
    https://issues.apache.org/jira/browse/proton-68


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/buffer.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/codec.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/cproton.i 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver_extras.h
1442452 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/error.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/framing.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/import_export.h
PRE-CREATION 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/message.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/messenger.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/parser.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/sasl.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/scanner.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/types.h 1442452

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/util.h 1442452


Diff: https://reviews.apache.org/r/9299/diff/


Testing
-------

gcc on linux, and Visual Studio on Windows


Thanks,

Cliff Jansen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message