qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request: QPID-4555: HA Add declaredExclusive management property to Queues
Date Tue, 05 Feb 2013 17:19:20 GMT


> On Feb. 5, 2013, 3:42 p.m., Ted Ross wrote:
> > This looks ok to me.
> > 
> > A couple of thoughts:
> > 
> > 1) Java broker...  Before you commit, run a build of the Java broker.  It will probably
fail in the module that handles management requests.  It's fairly easy to figure out how to
add a placeholder for a new attribute.
> > 
> > 2) declaredExclusive in the queue-declare event.  Is this not redundant with the
"exclusive" attribute since this event is only generated upon declaration of the queue?
> 
> Alan Conway wrote:
>     2 - its not equivalent, that's the origin of the problem. "exclusive" can change
over the lifetime of the queue if ownership is released or re-acquired.

btw QMF support was removed from the java broker so you no longer need to worry about breaking
it


- Gordon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9258/#review16112
-----------------------------------------------------------


On Feb. 5, 2013, 3:33 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9258/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 3:33 p.m.)
> 
> 
> Review request for qpid, Gordon Sim, Kenneth Giusti, and Ted Ross.
> 
> 
> Description
> -------
> 
> QPID-4555: HA Add declaredExclusive management property to Queues
> 
> The "exclusive" management property can change over the lifetime of a queue.
> This creates race conditions where primary and backup disagree over whether a
> queue is replicated. To resolve this, added a new management property
> "declaredExclusive" which is set when the queue is created and not modified.
> 
> Do we need to co-ordinate with the Java build over this change to the schema?
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1441163 
>   /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1441163 
>   /trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1441163 
>   /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1441163 
>   /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1441163 
>   /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1441163 
>   /trunk/qpid/cpp/src/qpid/ha/ReplicationTest.cpp 1441163 
>   /trunk/qpid/cpp/src/tests/ha_tests.py 1441163 
>   /trunk/qpid/specs/management-schema.xml 1441163 
> 
> Diff: https://reviews.apache.org/r/9258/diff/
> 
> 
> Testing
> -------
> 
> make check
> ha tests running 2  hours now without failure.
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message