qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Review Request: optionally set warning flags only if gcc version supports them
Date Sat, 09 Feb 2013 08:36:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9394/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher, Kenneth Giusti, Keith Wall, and Rafael Schloming.


Description
-------

test gcc version and set flags based on that.  Code stolen from the large qpid/cpp/src/CMakeLists.txt
file.  I poked around the gcc docs and determined that they all showed up at the same time
in 4.3.0.

Please comment if you find the warning message too scary or too pip-squeaky. 

I tried to use CMake's CHECK_C_COMPILER_FLAG() to test each flag and add it separately (oh,
so elegant), but it didn't work at all, and the function definition changtes a lot between
2.6 and 2.8.  So I opted for the simpler solution you see here.


This addresses bug PROTON-221.
    https://issues.apache.org/jira/browse/PROTON-221


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1444335 

Diff: https://reviews.apache.org/r/9394/diff/


Testing
-------

Just on rhel6.  I clearly need a test rhel5 VM to augment my Windows and Solaris VMs.


Thanks,

Cliff Jansen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message