qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Review Request: PROTON-200: messenger::recv(-1) allows unlimited credit to all receivers.
Date Mon, 18 Feb 2013 18:44:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9503/
-----------------------------------------------------------

Review request for qpid, mick goulish and Rafael Schloming.


Description
-------

This implements the "recv(-1) api change:  passing -1 to messenger::recv() causes messenger
to grant one credit to every active receiver link.

Note this does not implement the same behavior for the Java implementation of messenger -
not sure even if the same bug is present with that implementation.


This addresses bug proton-200.
    https://issues.apache.org/jira/browse/proton-200


Diffs
-----

  /proton/trunk/proton-c/bindings/python/proton.py 1447222 
  /proton/trunk/proton-c/include/proton/cproton.i 1447222 
  /proton/trunk/proton-c/include/proton/messenger.h 1447222 
  /proton/trunk/proton-c/src/messenger.c 1447222 
  /proton/trunk/tests/python/proton_tests/messenger.py 1447222 

Diff: https://reviews.apache.org/r/9503/diff/


Testing
-------

additional python unit test to exercise this problem.


Thanks,

Kenneth Giusti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message