qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request: PROTON-200: messenger::recv(-1) allows unlimited credit to all receivers.
Date Mon, 18 Feb 2013 21:28:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9503/#review16713
-----------------------------------------------------------



/proton/trunk/proton-c/bindings/python/proton.py
<https://reviews.apache.org/r/9503/#comment35430>

    should update the docs to reflec the optional parameter



/proton/trunk/proton-c/include/proton/messenger.h
<https://reviews.apache.org/r/9503/#comment35440>

    I'd document the semantics a bit more vaguely here. What we're really doing is allowing
the limit to be managed internally. Saying that we allow at least one message from each peer
is actually more specific than we need/want to be.



/proton/trunk/proton-c/src/messenger.c
<https://reviews.apache.org/r/9503/#comment35442>

    Correct me if I'm wrong, but wont' this result in only 1 credit per link when unlimited
is set to true?
    
    I'd restructure this code to calculate prior to the loop how many credits each link should
have and then simply distribute those. If we're in the unlimited case we can then just choose
a reasonable per/link default.


- Rafael Schloming


On Feb. 18, 2013, 8:58 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9503/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 8:58 p.m.)
> 
> 
> Review request for qpid, mick goulish, Rafael Schloming, and Philip Harvey.
> 
> 
> Description
> -------
> 
> This implements the "recv(-1) api change:  passing -1 to messenger::recv() causes messenger
to grant one credit to every active receiver link.
> 
> Note this does not implement the same behavior for the Java implementation of messenger
- not sure even if the same bug is present with that implementation.
> 
> 
> This addresses bug proton-200.
>     https://issues.apache.org/jira/browse/proton-200
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/proton-c/bindings/python/proton.py 1447222 
>   /proton/trunk/proton-c/include/proton/cproton.i 1447222 
>   /proton/trunk/proton-c/include/proton/messenger.h 1447222 
>   /proton/trunk/proton-c/src/messenger.c 1447222 
>   /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java
1447222 
>   /proton/trunk/tests/python/proton_tests/messenger.py 1447222 
> 
> Diff: https://reviews.apache.org/r/9503/diff/
> 
> 
> Testing
> -------
> 
> additional python unit test to exercise this problem.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message