qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mick goulish" <m...@redhat.com>
Subject Re: Review Request: PROTON-200: messenger::recv(-1) allows unlimited credit to all receivers.
Date Tue, 19 Feb 2013 01:37:03 GMT


> On Feb. 19, 2013, 1:17 a.m., mick goulish wrote:
> > Ship It!

In my 2-send 1-receiver case, using this patch, I'm now getting interleaved messages at the
receiver as I expect.
Hooray ! 


- mick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9503/#review16727
-----------------------------------------------------------


On Feb. 18, 2013, 8:58 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9503/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 8:58 p.m.)
> 
> 
> Review request for qpid, mick goulish, Rafael Schloming, and Philip Harvey.
> 
> 
> Description
> -------
> 
> This implements the "recv(-1) api change:  passing -1 to messenger::recv() causes messenger
to grant one credit to every active receiver link.
> 
> Note this does not implement the same behavior for the Java implementation of messenger
- not sure even if the same bug is present with that implementation.
> 
> 
> This addresses bug proton-200.
>     https://issues.apache.org/jira/browse/proton-200
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/proton-c/bindings/python/proton.py 1447222 
>   /proton/trunk/proton-c/include/proton/cproton.i 1447222 
>   /proton/trunk/proton-c/include/proton/messenger.h 1447222 
>   /proton/trunk/proton-c/src/messenger.c 1447222 
>   /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java
1447222 
>   /proton/trunk/tests/python/proton_tests/messenger.py 1447222 
> 
> Diff: https://reviews.apache.org/r/9503/diff/
> 
> 
> Testing
> -------
> 
> additional python unit test to exercise this problem.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message