qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request: PROTON-200: messenger::recv(-1) allows unlimited credit to all receivers.
Date Tue, 19 Feb 2013 15:10:51 GMT


> On Feb. 18, 2013, 9:28 p.m., Rafael Schloming wrote:
> > /proton/trunk/proton-c/bindings/python/proton.py, line 371
> > <https://reviews.apache.org/r/9503/diff/1/?file=259617#file259617line371>
> >
> >     should update the docs to reflec the optional parameter

Now reads:

    """
    Receives up to I{n} messages into the incoming queue of the
    L{Messenger}. If I{n} is not specified, L{Messenger} will receive as many
    messages as it can buffer internally. This method will block until at least
    one message is available or the operation times out.
    """

Please let me know if that's ok, otherwise please give me the specific text you'd prefer.


> On Feb. 18, 2013, 9:28 p.m., Rafael Schloming wrote:
> > /proton/trunk/proton-c/include/proton/messenger.h, line 337
> > <https://reviews.apache.org/r/9503/diff/1/?file=259619#file259619line337>
> >
> >     I'd document the semantics a bit more vaguely here. What we're really doing
is allowing the limit to be managed internally. Saying that we allow at least one message
from each peer is actually more specific than we need/want to be.

Now reads:

/** Receives up to n messages into the incoming message queue of a
 * messenger. If n is -1, Messenger will be able to receive as many
 * messages as it can buffer internally.  Blocks until at least one
 * message is available in the incoming queue.
 *
 * @param[in] messenger the messenger
 * @param[in] n the maximum number of messages to receive or -1 to to
 * receive as many messages as it can buffer internally.
 *
 * @return an error code or zero on success
 * @see error.h
 */

Ditto previous comment.


- Kenneth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9503/#review16713
-----------------------------------------------------------


On Feb. 18, 2013, 8:58 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9503/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 8:58 p.m.)
> 
> 
> Review request for qpid, mick goulish, Rafael Schloming, and Philip Harvey.
> 
> 
> Description
> -------
> 
> This implements the "recv(-1) api change:  passing -1 to messenger::recv() causes messenger
to grant one credit to every active receiver link.
> 
> Note this does not implement the same behavior for the Java implementation of messenger
- not sure even if the same bug is present with that implementation.
> 
> 
> This addresses bug proton-200.
>     https://issues.apache.org/jira/browse/proton-200
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/proton-c/bindings/python/proton.py 1447222 
>   /proton/trunk/proton-c/include/proton/cproton.i 1447222 
>   /proton/trunk/proton-c/include/proton/messenger.h 1447222 
>   /proton/trunk/proton-c/src/messenger.c 1447222 
>   /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java
1447222 
>   /proton/trunk/tests/python/proton_tests/messenger.py 1447222 
> 
> Diff: https://reviews.apache.org/r/9503/diff/
> 
> 
> Testing
> -------
> 
> additional python unit test to exercise this problem.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message