qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request: C++ Broker queue creation limits require better granularity
Date Fri, 01 Mar 2013 22:17:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9703/#review17273
-----------------------------------------------------------

Ship it!


- Chug Rolke


On March 1, 2013, 9:53 p.m., Ernie Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9703/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 9:53 p.m.)
> 
> 
> Review request for qpid and Chug Rolke.
> 
> 
> Description
> -------
> 
> Implements acl queue limits per user.
> - Modifies existing code to parse the acl file
> - Adds code to count queues per user
> - Adds max queue count of 65530
> - Adds python tests
> 
> 
> This addresses bug QPID-4604.
>     https://issues.apache.org/jira/browse/QPID-4604
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1450922 
>   trunk/qpid/cpp/src/qpid/acl/AclData.h 1450922 
>   trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1450922 
>   trunk/qpid/cpp/src/qpid/acl/AclReader.h 1450922 
>   trunk/qpid/cpp/src/qpid/acl/AclReader.cpp 1450922 
>   trunk/qpid/cpp/src/qpid/acl/AclResourceCounter.h 1450922 
>   trunk/qpid/cpp/src/qpid/acl/AclResourceCounter.cpp 1450922 
>   trunk/qpid/cpp/src/tests/acl.py 1451307 
> 
> Diff: https://reviews.apache.org/r/9703/diff/
> 
> 
> Testing
> -------
> 
> Passes python tests:
> - limit on a named user
> - limit on a user in a group
> - two acl entries for same user, last entry is honored
> - limit of 0 on user is enforced
> - if all is specified, unnamed user gets all's limit
> - if all is not specified, unnamed user is denied
> 
> 
> Thanks,
> 
> Ernie Allen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message