qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajith Attapattu <rajit...@gmail.com>
Subject Comparing two JMS Destinations created using address strings.
Date Mon, 11 Mar 2013 21:04:54 GMT
Hi All,

While fixing QPID-3769, I came across this issue.

There are two options for implementing the equals method (and hashcode).

1. Check the "type" and "name" to ensure they both point to the same
"destination" (which could be a queue or an exchange in pre 1.0
terms).

2. Do a comprehensive check on the internal address data structure to
ensure that all fields, properties, options are the same.

(Please note that comparing two address strings is not a good idea as
there can whitespaces).

I prefer option one and have pasted the patch as a comment on the JIRA

What do others think?

Regards,

Rajith

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message