qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0'
Date Wed, 01 May 2013 17:49:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10872/
-----------------------------------------------------------

(Updated May 1, 2013, 5:49 p.m.)


Review request for qpid, Andrew Stitcher and Gordon Sim.


Changes
-------

Fixed qpidd port printing logic: print port only if --port=0, regardless of --transport.

Use --transport and --port in qpidd-p0, avoids "no such transport tcp" errors from Broker::getPort()
which is called even if port != 0.

Added gordon as reviewer


Description (updated)
-------

QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0'

qpidd-p0 script binds a new port to a socket using bind(0), and then
execs qpidd using the --socket-fd option to pass the socket to qpidd.

New broker option --tcp-listen can disable TCP listening when using --socket-fd.

Fixed qpidd port printing logic: print port only if --port=0, regardless of --transport.


Diffs (updated)
-----

  /trunk/qpid/cpp/src/posix/QpiddBroker.cpp 1478115 
  /trunk/qpid/cpp/src/qpid/broker/posix/SocketFDPlugin.cpp 1478115 
  /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1478115 
  /trunk/qpid/cpp/src/tests/CMakeLists.txt 1478115 
  /trunk/qpid/cpp/src/tests/qpidd-p0 PRE-CREATION 

Diff: https://reviews.apache.org/r/10872/diff/


Testing (updated)
-------

make check


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message