qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Review Request: QPID-4886: Pass non-const reference to Message in QueueObserver functions.
Date Fri, 24 May 2013 14:16:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11378/
-----------------------------------------------------------

Review request for qpid, Gordon Sim and Kenneth Giusti.


Description
-------

QPID-4886: Pass non-const reference to Message in QueueObserver functions.

The HA plugin needs to modify a message in QueueObserver::enqueued to attach a HA ID to it.
Other plugins may need to similarly annotate messages at QueueObserver call points.
Need to remove the "const" qualifier for Message arguments to QueueObserver methods to enable
this.


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.h 1486017 
  /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.cpp 1486017 
  /trunk/qpid/cpp/src/qpid/broker/Queue.h 1486017 
  /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1486017 
  /trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1486017 
  /trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1486017 
  /trunk/qpid/cpp/src/qpid/broker/QueueObserver.h 1486017 
  /trunk/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1486017 
  /trunk/qpid/cpp/src/qpid/broker/ThresholdAlerts.cpp 1486017 
  /trunk/qpid/cpp/src/qpid/ha/QueueGuard.h 1486017 
  /trunk/qpid/cpp/src/qpid/ha/QueueGuard.cpp 1486017 
  /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1486017 

Diff: https://reviews.apache.org/r/11378/diff/


Testing
-------

make test


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message