qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request: QPID-4886: Pass non-const reference to Message in QueueObserver functions.
Date Wed, 29 May 2013 15:20:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11378/#review21156
-----------------------------------------------------------

Ship it!


Ship It!

- Kenneth Giusti


On May 29, 2013, 2:36 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11378/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 2:36 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Kenneth Giusti.
> 
> 
> Description
> -------
> 
> QPID-4886: Pass non-const reference to Message in QueueObserver functions.
> 
> Based on discussion on https://reviews.apache.org/r/11378/ we will not modify
> QueueObserver to allow message modification as it violates the existing
> semantics. Instead this patch introduces a new class MessageInterceptor for that
> purpose.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/MessageInterceptor.h PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/broker/Queue.h 1487501 
>   /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1487501 
> 
> Diff: https://reviews.apache.org/r/11378/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message