qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-4886) Pass non-const reference to Message in QueueObserver functions.
Date Tue, 28 May 2013 17:06:30 GMT

    [ https://issues.apache.org/jira/browse/QPID-4886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668455#comment-13668455

Alan Conway commented on QPID-4886:

Review at https://reviews.apache.org/r/11378/

The proposal is to leave the const qualifier in QueueObserver, since the name "observer" implies
no change is made to the thing observed. 
We will introduce a new interface for entities that need to modify messages as they go through
the system.
> Pass non-const reference to Message in QueueObserver functions.
> ---------------------------------------------------------------
>                 Key: QPID-4886
>                 URL: https://issues.apache.org/jira/browse/QPID-4886
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker
>    Affects Versions: 0.23
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>             Fix For: 0.23
> The HA plugin needs to modify a message in QueueObserver::enqueued to attach a HA ID
to it. Other plugins may need to similarly annotate messages at QueueObserver call points.
> Need to remove the "const" qualifier for Message arguments to QueueObserver methods to
enable this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message