qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: C++ code spring cleaning - mostly removing unused stuff, and tidying up some of the interfaces
Date Tue, 04 Jun 2013 17:09:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11628/
-----------------------------------------------------------

(Updated June 4, 2013, 5:09 p.m.)


Review request for qpid, Alan Conway, Gordon Sim, Kenneth Giusti, and Ted Ross.


Changes
-------

I've finished constructing the review:

Each of the changes to the diff represents an individual and usually fairly small change (except
the last which is a fix up for the autotools build)

I'm mostly interested in a sanity check because most of the changes are straightforward, but
in the end quite a lot of code is changed. The change merging broker::Connection and broker::ConnectionState
may be controversial as it's a larger than the others.

In any case all comments welcome.


Description
-------

A bunch of tidy ups to the C++ qpid code see the JIRA for a more detailed breakdown.

Change 1. - Remove unused members in Connector interface.


This addresses bug QPID-4905.
    https://issues.apache.org/jira/browse/QPID-4905


Diffs
-----

  /trunk/qpid/cpp/src/CMakeLists.txt 1489458 
  /trunk/qpid/cpp/src/Makefile.am 1489458 
  /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.h 1489458 
  /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/Broker.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/Connection.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1489458 
  /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/client/ConnectionImpl.h 1489458 
  /trunk/qpid/cpp/src/qpid/client/ConnectionImpl.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/client/Connector.h 1489458 
  /trunk/qpid/cpp/src/qpid/client/RdmaConnector.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/client/TCPConnector.h 1489458 
  /trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/framing/OutputHandler.h 1489458 
  /trunk/qpid/cpp/src/qpid/framing/amqp_framing.h 1489458 
  /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1489458 
  /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1489458 
  /trunk/qpid/cpp/src/qpid/sys/ConnectionInputHandler.h 1489458 
  /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandler.h 1489458 
  /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1489458 
  /trunk/qpid/cpp/src/qpid/sys/TimeoutHandler.h 1489458 

Diff: https://reviews.apache.org/r/11628/diff/


Testing
-------

cmake: make ; make test.
autotools: make ; make check


Thanks,

Andrew Stitcher


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message