qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request: C++ code spring cleaning - mostly removing unused stuff, and tidying up some of the interfaces
Date Thu, 06 Jun 2013 12:19:44 GMT


> On June 6, 2013, 12:18 p.m., Gordon Sim wrote:
> >

Also... there are no tests for heartbeats and since this touches those codepaths, have you
verified it still works?


- Gordon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11628/#review21516
-----------------------------------------------------------


On June 4, 2013, 5:09 p.m., Andrew Stitcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11628/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 5:09 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, Kenneth Giusti, and Ted Ross.
> 
> 
> Description
> -------
> 
> A bunch of tidy ups to the C++ qpid code see the JIRA for a more detailed breakdown.
> 
> Change 1. - Remove unused members in Connector interface.
> 
> 
> This addresses bug QPID-4905.
>     https://issues.apache.org/jira/browse/QPID-4905
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/CMakeLists.txt 1489458 
>   /trunk/qpid/cpp/src/Makefile.am 1489458 
>   /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.h 1489458 
>   /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/Connection.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1489458 
>   /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/client/ConnectionImpl.h 1489458 
>   /trunk/qpid/cpp/src/qpid/client/ConnectionImpl.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/client/Connector.h 1489458 
>   /trunk/qpid/cpp/src/qpid/client/RdmaConnector.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/client/TCPConnector.h 1489458 
>   /trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/framing/OutputHandler.h 1489458 
>   /trunk/qpid/cpp/src/qpid/framing/amqp_framing.h 1489458 
>   /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1489458 
>   /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1489458 
>   /trunk/qpid/cpp/src/qpid/sys/ConnectionInputHandler.h 1489458 
>   /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandler.h 1489458 
>   /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1489458 
>   /trunk/qpid/cpp/src/qpid/sys/TimeoutHandler.h 1489458 
> 
> Diff: https://reviews.apache.org/r/11628/diff/
> 
> 
> Testing
> -------
> 
> cmake: make ; make test.
> autotools: make ; make check
> 
> 
> Thanks,
> 
> Andrew Stitcher
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message