qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Ross" <tr...@apache.org>
Subject Re: Review Request: QMF build on Windows
Date Thu, 06 Jun 2013 12:35:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11665/#review21518
-----------------------------------------------------------

Ship it!


This looks like an improvement.

- Ted Ross


On June 6, 2013, 2:57 a.m., Steve Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11665/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 2:57 a.m.)
> 
> 
> Review request for qpid.
> 
> 
> Description
> -------
> 
> Allow QMF to build on Windows using cmake. Resolve compile errors related to partial
template specialization on Visual Studio.
> 
> 
> This addresses bug QPID-4909.
>     https://issues.apache.org/jira/browse/QPID-4909
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/CMakeLists.txt 1490097 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qmf/Agent.cpp 1490097 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qmf/AgentSession.cpp 1490097

>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/AddressParser.h
1490097 
> 
> Diff: https://reviews.apache.org/r/11665/diff/
> 
> 
> Testing
> -------
> 
> Build.
> 
> 
> Thanks,
> 
> Steve Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message