qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0'
Date Mon, 17 Jun 2013 15:25:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10872/#review21983
-----------------------------------------------------------

Ship it!


I think what this is a long term solution to the testing problem. Whereas --port 0 is a bad
idea and needs to be removed eventually.

So given what Gordon has done this is important but no longer urgent.

However if you've already done the work then we should just commit it.

- Andrew Stitcher


On June 17, 2013, 2:34 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10872/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 2:34 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Gordon Sim.
> 
> 
> Description
> -------
> 
> QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0'
> 
> qpidd-p0 script binds a new port to a socket using bind(0), and then
> execs qpidd using the --socket-fd option to pass the socket to qpidd.
> 
> Changes:
> - Added qpidd-p0
> - Fixed qpidd port printing logic: print port only if --port=0, regardless of --transport.
> - New option --listen-disable to disable specific transport listeners.
> 
> WIP: astitcher disable-transpor from https://reviews.apache.org/r/10894/
> 
> 
> This addresses bug qpid-4745.
>     https://issues.apache.org/jira/browse/qpid-4745
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/posix/QpiddBroker.cpp 1478313 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1478313 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1478313 
>   /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1478313 
>   /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1478313 
>   /trunk/qpid/cpp/src/tests/CMakeLists.txt 1478313 
>   /trunk/qpid/cpp/src/tests/Makefile.am 1478313 
>   /trunk/qpid/cpp/src/tests/qpidd-p0 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10872/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message