qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-4905) C++ Broker/common code needs tidying up of obsolete/unused code
Date Tue, 04 Jun 2013 15:23:20 GMT

    [ https://issues.apache.org/jira/browse/QPID-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674484#comment-13674484
] 

Andrew Stitcher commented on QPID-4905:
---------------------------------------

The interface sys::Timeout is not really used as an interface in itself anymore.

The member idleOut() is never called anywhere.

The member idleIn() is called once as part of a timer callback, however this time callback
can just as easily call the actual implementing class as it is in the same file anyway.
                
> C++ Broker/common code needs tidying up of obsolete/unused code
> ---------------------------------------------------------------
>
>                 Key: QPID-4905
>                 URL: https://issues.apache.org/jira/browse/QPID-4905
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, C++ Client
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>
> There is quite a lot of code in the Qpid C++ code base that is vestigial (like your appendix).
In the name of easier code maintenance we should remove it.
> I will detail some of the things I have found as comments to this JIRA, if they attract
sufficient comment they can be broken out as subtasks to this issue.
> Most of these issues are small and involve unused member functions or unused/potentially
unused interfaces or interfaces implemented unnecessarily.
> Much of this is still the fallout of removing the old cluster work which added hook (and
hence interfaces) in lots of code, now that old cluster is gone the interfaces/members remain,
but are unused anywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message