qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-4958) Java Performance Tests - race condition client registration detection causes tests to hang
Date Mon, 01 Jul 2013 08:51:20 GMT

    [ https://issues.apache.org/jira/browse/QPID-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696660#comment-13696660
] 

ASF subversion and git services commented on QPID-4958:
-------------------------------------------------------

Commit 1498306 from [~philharveyonline]
[ https://svn.apache.org/r1498306 ]

QPID-4958: fixed race condition in ClientRegistry that caused awaitClients to hang if
all registrations arrive between the initial numberAbsent() call and _lock.wait().
                
> Java Performance Tests - race condition client registration detection causes tests to
hang
> ------------------------------------------------------------------------------------------
>
>                 Key: QPID-4958
>                 URL: https://issues.apache.org/jira/browse/QPID-4958
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Performance Tests
>    Affects Versions: 0.22
>            Reporter: Philip Harvey
>            Assignee: Philip Harvey
>         Attachments: 0001-QPID-4958-fixed-race-condition-in-ClientRegistry-tha.patch
>
>
> Occasionally various tests in ControllerAndClientTest fail with errors such as:
> {noformat}
> main 2013-06-25 14:39:25,539 ERROR [qpid.disttest.controller.TestRunner] Couldn't run
test
> org.apache.qpid.disttest.DistributedTestException: After 30000ms ... Timed out waiting
for command responses ... Expecting 10 more responses.
>     at org.apache.qpid.disttest.controller.TestRunner.awaitLatch(TestRunner.java:293)
>     at org.apache.qpid.disttest.controller.TestRunner.awaitCommandResponses(TestRunner.java:183)
>     at org.apache.qpid.disttest.controller.TestRunner.runParts(TestRunner.java:130)
>     at org.apache.qpid.disttest.controller.TestRunner.run(TestRunner.java:103)
>     at org.apache.qpid.disttest.controller.Controller.runAllTests(Controller.java:171)
>     at org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.runTestsForTwoClients(ControllerAndClientTest.java:195)
>     at org.apache.qpid.systest.disttest.controllerandclient.ControllerAndClientTest.testProducerAndThreeConsumersInSeparateClients(ControllerAndClientTest.java:136)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
> The relevant test log excerpts are shown below.
> {noformat}
> main 2013-06-25 14:38:35,357 INFO [qpid.disttest.controller.Controller] Awaiting client
registrations
> ...
> 908 Dispatcher-1-Conn-2 2013-06-25 14:38:35,448 INFO [qpid.disttest.controller.ClientRegistry]
Client registered: 63a95928-7d12-48ad-9326-133da9a0ddb6
> ...
> 920 Dispatcher-1-Conn-2 2013-06-25 14:38:35,450 INFO [qpid.disttest.controller.ClientRegistry]
Client registered: 2510ce56-20d4-43a2-84db-193a87b1cfec
> ...
> {noformat}
> Client thread timing out after the 5 seconds set by the JUnit test:
> {noformat}
> 997 2510ce56-20d4-43a2-84db-193a87b1cfec-thread 2013-06-25 14:38:40,423 DEBUG [apache.qpid.client.AMQSession]
Closing session: org.apache.qpid.client.AMQSes sion_0_8@5e111b5c
> {noformat}
> Controller sends test set-up commands, 20 seconds after "Awaiting client registrations".
This happens to be the length of the client registration time-out, suggesting that the "await
client registrations" code didn't notice that client registrations.
> {noformat}
> 1080 main 2013-06-25 14:38:55,476 DEBUG [qpid.disttest.controller.TestRunner] About to
send 10 command(s) 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message