qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gordon Sim <g...@redhat.com>
Subject Re: RFQ 0.24: Two JIRAs
Date Mon, 12 Aug 2013 10:31:23 GMT
On 08/12/2013 11:26 AM, Gordon Sim wrote:
> (Also, minor nit, you checked
> in commented out code rather than removing it).

What's worse, you left a printf statement in for the ruby which I assume 
was just for debug:

>> Modified: qpid/trunk/qpid/cpp/include/qpid/swig_ruby_typemaps.i
>> URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/include/qpid/swig_ruby_typemaps.i?rev=1512482&r1=1512481&r2=1512482&view=diff
>> ==============================================================================
>> --- qpid/trunk/qpid/cpp/include/qpid/swig_ruby_typemaps.i (original)
>> +++ qpid/trunk/qpid/cpp/include/qpid/swig_ruby_typemaps.i Fri Aug  9 20:28:59 2013
>> @@ -27,9 +27,16 @@
>>       void RbToList(VALUE, qpid::types::Variant::List*);
>>
>>       qpid::types::Variant RbToVariant(VALUE value) {
>> +      printf("RbToVariant is of type %d\n", TYPE(value));
>>           switch (TYPE(value)) {
>>           case T_FLOAT:   return qpid::types::Variant(NUM2DBL(value));
>> -        case T_STRING:  return qpid::types::Variant(StringValuePtr(value));
>> +        case T_STRING: {
>> +          qpid::types::Variant v = qpid::types::Variant();
>> +          v = StringValuePtr(value));
>> +          v.setEncoding("utf8");
>> +          return v;
>> +        }
>> +          break;
>>           case T_FIXNUM:  return qpid::types::Variant((int64_t) FIX2LONG(value));
>>           case T_BIGNUM:  return qpid::types::Variant((int64_t) NUM2LL(value));
>>           case T_TRUE:    return qpid::types::Variant(true);




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message