qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 13885: provide direct access to reconnect/replay
Date Tue, 03 Sep 2013 14:15:37 GMT


> On Aug. 30, 2013, 1:59 p.m., Alan Conway wrote:
> > /trunk/qpid/cpp/examples/messaging/server.cpp, line 54
> > <https://reviews.apache.org/r/13885/diff/1/?file=345639#file345639line54>
> >
> >     The basic example should use the default/simplest approach, i.e. automatic reconnect.
Suggest creating a new demo for this feature.
> 
> Gordon Sim wrote:
>     You can of course use automatic reconnect even with this example. And of course spout/drain
are perhaps the primary examples, which I didn't change at all. This seemed like a simple
way to show/try the two approaches to reconnecting. Would it be better or worse if I checked
in a copy of this example, say server_reconnect, and left the original server as is (i.e.
the two example would only differ by the change here)?

Yes, I think a separate server_reconnect example is better.


- Alan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13885/#review25795
-----------------------------------------------------------


On Aug. 30, 2013, 3:58 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13885/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2013, 3:58 p.m.)
> 
> 
> Review request for qpid.
> 
> 
> Bugs: QPID-4932
>     https://issues.apache.org/jira/browse/QPID-4932
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The reconnect feature is at present rather and 'all or nothing' solution. This proposal
improves on that by exposing a new reconnect() method allowing the application to drive the
reconnection process without having to do all the session/sender/receiver re-establishment
or message replay.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/examples/messaging/server.cpp 1518233 
>   /trunk/qpid/cpp/include/qpid/messaging/Connection.h 1518233 
>   /trunk/qpid/cpp/src/qpid/client/Connection.h 1518233 
>   /trunk/qpid/cpp/src/qpid/client/Connection.cpp 1518233 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/ConnectionImpl.h 1518233 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/ConnectionImpl.cpp 1518233 
>   /trunk/qpid/cpp/src/qpid/messaging/Connection.cpp 1518233 
>   /trunk/qpid/cpp/src/qpid/messaging/ConnectionImpl.h 1518233 
>   /trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.h 1518233 
>   /trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1518233 
>   /trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionHandle.h 1518233 
>   /trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionHandle.cpp 1518233 
> 
> Diff: https://reviews.apache.org/r/13885/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message