qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Review Request 14408: Messaging example hello_world core dumps when given a bad connection option
Date Mon, 30 Sep 2013 18:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14408/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Bugs: QPID-5196
    https://issues.apache.org/jira/browse/QPID-5196


Repository: qpid


Description
-------

If a misspelled connection option is present on the command line then hello_world.cpp throws.
Since the connection constructor is outside the try-catch block the program core dumps.

The fix is to move the connection constructor inside the try-catch. 


Diffs
-----

  trunk/qpid/cpp/examples/messaging/hello_world.cpp 1527685 

Diff: https://reviews.apache.org/r/14408/diff/


Testing
-------

There is no test for hello_world. With this fix both linux and windows versions print useful
error messages and exit with error status.


Thanks,

Chug Rolke


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message