qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ernie Allen" <eal...@redhat.com>
Subject Re: Review Request 15322: Add management interface to return the connections for a dispatch router
Date Fri, 08 Nov 2013 17:14:58 GMT


> On Nov. 7, 2013, 9:51 p.m., Ted Ross wrote:
> > This looks great!
> > 
> > One thing I would change is the "container" attribute in the connections object.
 It should be the name of the remote container for the connection, not this container.  We
can add a container object to provide information about the local container.

I don't see the linkage between the connection and the remote container's name? Is it available
through the context or link_context? 


- Ernie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15322/#review28453
-----------------------------------------------------------


On Nov. 7, 2013, 8:47 p.m., Ernie Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15322/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 8:47 p.m.)
> 
> 
> Review request for qpid and Ted Ross.
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Respond to a management request to display the list of connections for a dispatch router.
> The router responds with the following info for each connection: 
> container - the name of the router handling the request
> state     - the state of the connection (Connecting, Opening, Operational, Failed, User)

> host      - the host of the connection's container 
> port      - the post of the connection's container
> sasl      - the sasl mechanism list of the connection's container
> role      - the role of the connection's container
> 
> tools/src/py/qdstat was updated to honor the -c command line switch. 
> ./qdstat -c -b localhost:20001
>   container  state        host     port   sasl       role
>   ===========================================================
>   QDR.A      Operational  0.0.0.0  20002  ANONYMOUS  inter-router
>   QDR.A      Operational  0.0.0.0  20003  ANONYMOUS  inter-router
>   QDR.A      Operational  0.0.0.0  20004  ANONYMOUS  inter-router
> 
> 
> Diffs
> -----
> 
>   /dispatch/trunk/src/server.c 1538673 
>   /dispatch/trunk/src/server_private.h 1538673 
>   /dispatch/trunk/tools/src/py/qdstat 1538673 
> 
> Diff: https://reviews.apache.org/r/15322/diff/
> 
> 
> Testing
> -------
> 
> Start a network of routers
> Display connections using qdstat -c for each router
> Verify connections match config file entries for each router
> Kill a router in the network
> Verify connections to the killed router are no longer listed
> Restart the killed router
> Verify connections to the restarted router are displayed
> 
> 
> Thanks,
> 
> Ernie Allen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message