qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request 15854: Windows SSL client certificates should not be tied to SASL EXTERNAL
Date Tue, 26 Nov 2013 17:47:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15854/#review29441
-----------------------------------------------------------

Ship it!


As far as I understand, it this looks fine.

- Andrew Stitcher


On Nov. 26, 2013, 8:51 a.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15854/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 8:51 a.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Chug Rolke, and Steve Huston.
> 
> 
> Bugs: QPID-5375
>     https://issues.apache.org/jira/browse/QPID-5375
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Based on the JIRA, this patch decouples the certificate loading from the SASL mechanism
and remembers any problem with client certificate loading in case there is a later failure
in the connection attributable to the lack of a client certificate.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/client/windows/SslConnector.cpp
1545560 
> 
> Diff: https://reviews.apache.org/r/15854/diff/
> 
> 
> Testing
> -------
> 
> Windows 7 client versus RHEL 6 client, broker requiring or not requiring client certificates,
SASL mechanisms EXTERNAL, PLAIN, ANONYMOUS.
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message