qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darryl Pierce" <dpie...@redhat.com>
Subject Re: Review Request 15978: Fix python binding dependencies to avoid unnecessary rebuilds
Date Wed, 04 Dec 2013 14:18:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15978/#review29733
-----------------------------------------------------------

Ship it!


Verified it as working. Did a build and another and didn't see anything rebuild. Touched various
Swig descriptors and saw rebuilds as expected. Looks good!

- Darryl Pierce


On Dec. 3, 2013, 10:33 p.m., Andrew Stitcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15978/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 10:33 p.m.)
> 
> 
> Review request for qpid and Darryl Pierce.
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Fix the binding dependencies so that we no longer keep on rebuilding the python swig
bindings unnecessarily
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/bindings/qmf2/python/CMakeLists.txt 1547601 
>   /trunk/qpid/cpp/bindings/qmf2/python/cqmf2.i PRE-CREATION 
>   /trunk/qpid/cpp/bindings/qmf2/python/python.i 1547601 
>   /trunk/qpid/cpp/bindings/qmf2/ruby/CMakeLists.txt 1547601 
>   /trunk/qpid/cpp/bindings/qpid/python/CMakeLists.txt 1547601 
>   /trunk/qpid/cpp/bindings/qpid/python/python.i 1547601 
>   /trunk/qpid/cpp/bindings/qpid/python/qpid_messaging.i PRE-CREATION 
>   /trunk/qpid/cpp/bindings/qpid/ruby/CMakeLists.txt 1547601 
> 
> Diff: https://reviews.apache.org/r/15978/diff/
> 
> 
> Testing
> -------
> 
> build; rebuild;
> 
> Does not rebuild the python bindings
> 
> 
> Thanks,
> 
> Andrew Stitcher
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message