qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 16018: QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
Date Thu, 05 Dec 2013 20:11:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16018/
-----------------------------------------------------------

(Updated Dec. 5, 2013, 8:11 p.m.)


Review request for qpid, Andrew Stitcher, Justin Ross, and Steve Huston.


Changes
-------

Made this a separte JIRA and fixed the problem Andrew pointed out. I'd like to put this in
0.26.


Summary (updated)
-----------------

QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.


Bugs: QPID-5307
    https://issues.apache.org/jira/browse/QPID-5307


Repository: qpid


Description (updated)
-------

QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.

On windows, acl-file was not recognizing drive-prefixed paths (e.g. c:\foo)
as absolute and was trying to interpret them relative to the brokers data-dir.

This commit fixes the problem and adds a general-purpose Path class that can be
a collection point for any other path-related portability problems that come up.


Diffs (updated)
-----

  /trunk/qpid/cpp/src/CMakeLists.txt 1548180 
  /trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1548180 
  /trunk/qpid/cpp/src/qpid/sys/Path.h PRE-CREATION 
  /trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp PRE-CREATION 
  /trunk/qpid/cpp/src/qpid/sys/windows/Path.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/16018/diff/


Testing
-------


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message