qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request 16018: QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
Date Thu, 05 Dec 2013 20:19:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16018/#review29831
-----------------------------------------------------------

Ship it!


Except for the nit picking below this is good to go


/trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp
<https://reviews.apache.org/r/16018/#comment57309>

    Being nitpicky:
    
    I think it's more usual to have a message like:
    
    <context info>: strerror(errno)
    (certainly perror() does this)
    
    Also "invalid path" is ambiguous, how about:
    
    string("stat() failed: ") + path + ": " + strError(errno)
    
    [And also for the windows version]


- Andrew Stitcher


On Dec. 5, 2013, 8:11 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16018/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 8:11 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Justin Ross, and Steve Huston.
> 
> 
> Bugs: QPID-5307
>     https://issues.apache.org/jira/browse/QPID-5307
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
> 
> On windows, acl-file was not recognizing drive-prefixed paths (e.g. c:\foo)
> as absolute and was trying to interpret them relative to the brokers data-dir.
> 
> This commit fixes the problem and adds a general-purpose Path class that can be
> a collection point for any other path-related portability problems that come up.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/CMakeLists.txt 1548180 
>   /trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1548180 
>   /trunk/qpid/cpp/src/qpid/sys/Path.h PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp PRE-CREATION 
>   /trunk/qpid/cpp/src/qpid/sys/windows/Path.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16018/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message