qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alan Conway <acon...@redhat.com>
Subject Re: [C++] Getting rid of file:line in QPID_MSG
Date Thu, 30 Jan 2014 18:02:05 GMT
On Wed, 2014-01-29 at 15:36 -0500, Chuck Rolke wrote:
> QPID_MSG has lots of uses with identical args. The file/line is the only way to tell
them apart.
> 
Gahh, you're right.

> Couldn't you just define another macro that's just like QPID_MSG but without the file/line
and use that where you need it leaving the rest alone?
Yes, that is probably the right thing to do. Thanks for the input.

> 
> ----- Original Message -----
> > From: "Alan Conway" <aconway@redhat.com>
> > To: "dev" <dev@qpid.apache.org>
> > Sent: Wednesday, January 29, 2014 11:45:33 AM
> > Subject: [C++] Getting rid of file:line in QPID_MSG
> > 
> > There's a convenience macro QPID_MSG in qpid/cpp/src/qpid/Msg.h that is
> > used to format exception messages all over the place.
> > 
> > The current implementation includes the "filename:line" source location
> > where the macro is used.
> > 
> > I propose to take the filename:line out. It is not necessary for
> > developers (you can  find the source of a message by grepping for the
> > message text) and it adds a lot of useless non-information to messages
> > that are read by users. It was my misguided self who put it in there
> > long ago, if anyone thinks it is really useful please shout now and
> > we'll argue about it, else I'll excise it. Silence = consent.
> > 
> > Cheers,
> > Alan.
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: dev-help@qpid.apache.org
> > 
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message