qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alan Conway <acon...@redhat.com>
Subject Re: [C++] Getting rid of file:line in QPID_MSG
Date Thu, 30 Jan 2014 18:26:19 GMT
On Wed, 2014-01-29 at 11:10 -0600, Kerry Bonin wrote:
> FWIW, I've been bit in the past when I tried this, when a small subset of
> our messages were generic enough that we got multiple hits, and the
> developer performing the search guessed incorrectly which was the actual
> source location.
> 

OK, OK, I take it back already!

> 
> On Wed, Jan 29, 2014 at 10:45 AM, Alan Conway <aconway@redhat.com> wrote:
> 
> > There's a convenience macro QPID_MSG in qpid/cpp/src/qpid/Msg.h that is
> > used to format exception messages all over the place.
> >
> > The current implementation includes the "filename:line" source location
> > where the macro is used.
> >
> > I propose to take the filename:line out. It is not necessary for
> > developers (you can  find the source of a message by grepping for the
> > message text) and it adds a lot of useless non-information to messages
> > that are read by users. It was my misguided self who put it in there
> > long ago, if anyone thinks it is really useful please shout now and
> > we'll argue about it, else I'll excise it. Silence = consent.
> >
> > Cheers,
> > Alan.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: dev-help@qpid.apache.org
> >
> >



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message