qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 17511: Suggested fix for the paged queue file issues
Date Thu, 30 Jan 2014 17:49:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17511/#review33229
-----------------------------------------------------------

Ship it!


Ship It!

- Alan Conway


On Jan. 29, 2014, 10:09 p.m., Andrew Stitcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17511/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 10:09 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Pavel Moravec.
> 
> 
> Bugs: QPID-5485 and QPID-5486
>     https://issues.apache.org/jira/browse/QPID-5485
>     https://issues.apache.org/jira/browse/QPID-5486
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> 1. Use a directory solely for paged queue files, so there can be no file name clashes.
> 2. Don't require exclusive file access, and truncate any previous file.
> 3. by default use <datadir>/pq if paging-dir not specified otherwise use paging-dir.
> 4. If neither specified then error on page queue creation (this was broken before and
would create files in the current directory which in the tests would succeed accidentally
because it would be ~/.qpidd because this is both the default data dir and pidfile dir)
> 5. Tiny refactoring in who holds the final page file path.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1562539 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1562539 
>   /trunk/qpid/cpp/src/qpid/broker/PagedQueue.h 1562539 
>   /trunk/qpid/cpp/src/qpid/broker/PagedQueue.cpp 1562539 
>   /trunk/qpid/cpp/src/qpid/broker/posix/BrokerDefaults.cpp 1562539 
>   /trunk/qpid/cpp/src/qpid/broker/windows/BrokerDefaults.cpp 1562539 
>   /trunk/qpid/cpp/src/qpid/sys/MemoryMappedFile.h 1562539 
>   /trunk/qpid/cpp/src/qpid/sys/posix/MemoryMappedFile.cpp 1562539 
>   /trunk/qpid/cpp/src/tests/run_paged_queue_tests 1562539 
> 
> Diff: https://reviews.apache.org/r/17511/diff/
> 
> 
> Testing
> -------
> 
> ctest -R page (both as is now and with the qpidd start line massaged with --no-data-dir
so it should fail)
> 
> 
> Thanks,
> 
> Andrew Stitcher
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message