qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec" <pmora...@redhat.com>
Subject Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction
Date Sat, 01 Feb 2014 11:30:41 GMT


> On Jan. 31, 2014, 4:36 p.m., Gordon Sim wrote:
> > /trunk/qpid/cpp/src/qpid/broker/DtxManager.h, line 54
> > <https://reviews.apache.org/r/17592/diff/1/?file=457723#file457723line54>
> >
> >     Rather than passing the default timeout through on each call, why not pass it
in to the constructor of DtxManager, and then simply use a member variable from createWork()?

Thanks for idea. Patch to follow..


- Pavel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17592/#review33331
-----------------------------------------------------------


On Feb. 1, 2014, 11:30 a.m., Pavel Moravec wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17592/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2014, 11:30 a.m.)
> 
> 
> Review request for qpid, Chug Rolke, Cliff Jansen, Kim van der Riet, and Steve Huston.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/QPID-5531
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5531
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> If a rogue external Transaction Manager forgets to commit/rollback a prepared DTX, Tpl
store keeps an orphaned enqueue record. To prevent it, every DTX transaction should have a
default timeout after that the broker automatically aborts the transaction.
> 
> QPID-5531 adds broker option dtx-default-timeout for that.
> 
> My concerns for review:
> - is 3600 seconds as default value proper? Isn't it too high?
> - ms-sql and/or ms-clfs store part of the patch (recoverTransaction method) has not been
even compiled
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1563386 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1563386 
>   /trunk/qpid/cpp/src/qpid/broker/DtxManager.h 1563386 
>   /trunk/qpid/cpp/src/qpid/broker/DtxManager.cpp 1563386 
>   /trunk/qpid/cpp/src/tests/legacystore/OrderingTest.cpp 1563386 
>   /trunk/qpid/cpp/src/tests/legacystore/SimpleTest.cpp 1563386 
>   /trunk/qpid/cpp/src/tests/legacystore/TransactionalTest.cpp 1563386 
>   /trunk/qpid/cpp/src/tests/legacystore/TwoPhaseCommitTest.cpp 1563386 
> 
> Diff: https://reviews.apache.org/r/17592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavel Moravec
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message