qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec" <pmora...@redhat.com>
Subject Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction
Date Tue, 04 Feb 2014 14:15:06 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 4, 2014, 2:15 p.m.)

Review request for qpid, Chug Rolke, Cliff Jansen, Kim van der Riet, and Steve Huston.


New version of patch, newly fixing automated test failure and adding another test there.

(Note, two auto-tests fail but independently on this patch: legacystore_OrderingTest and legacystore_TwoPhaseCommit,
due to valgrind issues)

Bugs: QPID-5531

Repository: qpid


If a rogue external Transaction Manager forgets to commit/rollback a prepared DTX, Tpl store
keeps an orphaned enqueue record. To prevent it, every DTX transaction should have a default
timeout after that the broker automatically aborts the transaction.

QPID-5531 adds broker option dtx-default-timeout for that.

My concerns for review:
- is 3600 seconds as default value proper? Isn't it too high?
- ms-sql and/or ms-clfs store part of the patch (recoverTransaction method) has not been even

Diffs (updated)

  /trunk/qpid/cpp/src/qpid/broker/Broker.h 1563872 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1563872 
  /trunk/qpid/cpp/src/qpid/broker/DtxManager.h 1563872 
  /trunk/qpid/cpp/src/qpid/broker/DtxManager.cpp 1563872 
  /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1563872 
  /trunk/qpid/cpp/src/tests/qpid-txtest.cpp 1563872 
  /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/dtx.py 1563872 

Diff: https://reviews.apache.org/r/17592/diff/



Pavel Moravec

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message