qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec" <pmora...@redhat.com>
Subject Re: Review Request 17592: QPID-5531 [C++ broker] Set timeout for every DTX transaction
Date Wed, 05 Feb 2014 08:36:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17592/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 8:36 a.m.)


Review request for qpid, Chug Rolke, Cliff Jansen, Kim van der Riet, and Steve Huston.


Changes
-------

Comments implemented.

Re "The default maximum allowed timeout is 3600 seconds." - qpidd --help already prints out
default values, e.g.:

  --dtx-max-timeout SECONDS (3600)                         Maximum allowed 
                                                           timeout for DTX 
                                                           transaction. A value
                                                           of zero disables 
                                                           maximum timeout 
                                                           limit checks and 
                                                           allows arbitrarily 
                                                           large timeout 
                                                           settings.


Bugs: QPID-5531
    https://issues.apache.org/jira/browse/QPID-5531


Repository: qpid


Description
-------

If a rogue external Transaction Manager forgets to commit/rollback a prepared DTX, Tpl store
keeps an orphaned enqueue record. To prevent it, every DTX transaction should have a default
timeout after that the broker automatically aborts the transaction.

QPID-5531 adds broker option dtx-default-timeout for that.

My concerns for review:
- is 3600 seconds as default value proper? Isn't it too high?
- ms-sql and/or ms-clfs store part of the patch (recoverTransaction method) has not been even
compiled


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/broker/Broker.h 1563872 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1563872 
  /trunk/qpid/cpp/src/qpid/broker/DtxManager.h 1563872 
  /trunk/qpid/cpp/src/qpid/broker/DtxManager.cpp 1563872 
  /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1563872 
  /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/dtx.py 1563872 

Diff: https://reviews.apache.org/r/17592/diff/


Testing
-------


Thanks,

Pavel Moravec


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message