qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-5579) [Java Broker] Build attribute meta data in the same way for REST API and for AMQP Management
Date Mon, 03 Mar 2014 15:01:30 GMT

    [ https://issues.apache.org/jira/browse/QPID-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918123#comment-13918123
] 

Robbie Gemmell commented on QPID-5579:
--------------------------------------

For https://svn.apache.org/r1571054
===============================

- This was always a Boolean, why is it not still? Actually, following the implementation it
looks like it is and will throw a ClassCastException. (From Queue).
{noformat}
+    // TODO - this should either be a boolean or maybe an enum
+    @ManagedAttribute
+    int getMessageGroupSharedGroups();
{noformat}

- These need wired up (they seem to be overriding implementations that might do the trick)
{noformat}
@@ -201,4 +201,34 @@ public class AmqpPortAdapter extends PortAdapter
         }
         return null;
     }
+
+    @Override
+    public boolean isTcpNoDelay()
+    {
+        return false;
+    }
+
+    @Override
+    public int getSendBufferSize()
+    {
+        return 0;
+    }
+
+    @Override
+    public int getReceiveBufferSize()
+    {
+        return 0;
+    }
+
+    @Override
+    public boolean getNeedClientAuth()
+    {
+        return false;
+    }
+
+    @Override
+    public boolean getWantClientAuth()
+    {
+        return false;
+    }
 }
{noformat}


- These need wired up (From ConnectionAdapter)
{noformat}
+    @Override
+    public String getRemoteProcessName()
+    {
+        return null;
+    }
+
+    @Override
+    public String getRemoteProcessPid()
+    {
+        return null;
+    }
{noformat}

- General comment. Should the ManagedAttribute/ManagedStatistic annotation perhaps have a
name attribute that we set to the constant defining the attribute name used for all other
implementation scenarios? Might help to keep the relationship more obvious.

Still working on the other big commit :)

> [Java Broker] Build attribute meta data in the same way for REST API and for AMQP Management
> --------------------------------------------------------------------------------------------
>
>                 Key: QPID-5579
>                 URL: https://issues.apache.org/jira/browse/QPID-5579
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Robbie Gemmell
>             Fix For: 0.27
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message