qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-5591) [Java Broker] Move responsibility for setting attribute values to AbstractConfiguredObject
Date Wed, 05 Mar 2014 09:34:44 GMT

    [ https://issues.apache.org/jira/browse/QPID-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920696#comment-13920696

Rob Godfrey commented on QPID-5591:

bq. This will fail if 'o' is null. I don't expect that comparison will ever happen, but I
saw you made that change elsewhere recently so... 

For compareTo throwing an NPE is actually the correct response

bq. Note that null is not an instance of any class, and e.compareTo(null) should throw a NullPointerException
even though e.equals(null) returns false.

(see http://docs.oracle.com/javase/7/docs/api/java/lang/Comparable.html)

All the other points should be addressed by r1574258

> [Java Broker] Move responsibility for setting attribute values to AbstractConfiguredObject
> ------------------------------------------------------------------------------------------
>                 Key: QPID-5591
>                 URL: https://issues.apache.org/jira/browse/QPID-5591
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: 0.27
> Allow attributes to be defined as being automatically set... that is AbstractConfiguredObject
takes responsibility for setting memberVariables within the subclass which represent the perceived
value of the attribute.
> The "actual" value of the attribute will still be returned from the map held by the AbstractConfiguredObject.
 Calling getAttribute will evaluate to the perceived value except where the attribute is marked
as secure in which case non "system" subjects will only receive an obfuscated value

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message