qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-5048) [Java] Implement a Maven 3 build system
Date Wed, 02 Apr 2014 12:30:18 GMT

    [ https://issues.apache.org/jira/browse/QPID-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957591#comment-13957591
] 

Robbie Gemmell commented on QPID-5048:
--------------------------------------

- We should decide what we are doing about the duplicate javax.servlet api dependency issue
we discussed before finalising the LICENCE+NOTICE files.
-- Likely to be changes in the broker managment-http plugin, and both client and broker 1.0
websocket plugins.


- This needs the Jetty info in it: qpid/java/amqp-1-0-client-websocket/src/main/assembly/NOTICE

- For qpid/java/broker/src/main/assembly/LICENSE
-- We need to say what the licences are specifically, and more clearly what bits they apply
to, usually achieved using a small header like 'this bundles the X jar which is under the
Y licence'.
-- We can probably format the crypto-js licence nicer...e.g I think it is actually the MIT
license and so I expect if formatted should match (other than copyright) the text beneath
for SLF4J (which would should be clear is for SLF4J-API and SLF4J-LOG4J)
-- For the Dojo entry, we dont need "+The text of the AFL and BSD licenses is reproduced below.
" since they aren't both, we picked BSD.

- For qpid/java/broker/src/main/assembly/NOTICE
-- We should be clearer which bit of the notices apply to which bits of the bundle, e.g the
'Servlet 3.0' is ambiguous right now because we have 2 variants.
-- We should include the derby copyright assignment to the ASF before the subsequent IBM copyright
related notice.
-- We dont need to repeat 'This product includes software developed at The Apache Software
Foundation' for individual deps as its mentioned at the top
-- We only need the copyright assignments for commons-logging and commons-codec, we dont need
the rest because we dont actually ship those bits.
-- We should include the copyright assignments for the other (possibly transitive) deps from
ASF projects (e.g servicemix bcel bundle, commons-foo)

> [Java] Implement a Maven 3 build system 
> ----------------------------------------
>
>                 Key: QPID-5048
>                 URL: https://issues.apache.org/jira/browse/QPID-5048
>             Project: Qpid
>          Issue Type: Task
>          Components: Build Tools
>            Reporter: Rob Godfrey
>            Assignee: Robbie Gemmell
>         Attachments: 0001-QPID-5048-Maven-POM-refactoring-names-descriptions-d.patch,
0001-QPID-5048-Maven-enahancements-to-remove-child-versio.patch, 0001-QPID-5048-Maven-enahancements-to-restructure-POM-hie.patch,
0001-QPID-5048-Moved-slf4j-deps-to-test-utils-to-workarou.patch, 0001-QPID-5048-added-basic-cpp-broker-test-profile.patch,
0001-QPID-5048-changes-get-perf-tests-running-again.patch, 0001-QPID-5048-dby-profiles-bdb-test-deps-and-config-for-.patch,
0001-QPID-5048-maven-license-plugin-optimisation-enhanced.patch, 0001-QPID-5048-modified-deployment-plugin-config-so-only-.patch,
0001-QPID-5048-new-maven-enforcer-plugin-rule-for-checkin.patch, 0001-QPID-5048-parent-pom-changes-for-release-license-and.patch,
0001-QPID-5048-split-out-systests-from-perftests-and-add-.patch, 0001-QPID-5048-surefire-site-coverage-and-jxr-config.patch,
0002-QPID-5048-Logging-dependency-and-configuration-tidy-.patch, 0002-QPID-5048-added-dependency-license-reference-checkin.patch,
0003-QPID-5048-logging-and-build-output-cleanup.patch, QPID-5048-maven-qpid-parent-changes.diff
>
>
> Implement a Maven build system which generates the same artefacts as the current ant
based build.  
> See: https://cwiki.apache.org/confluence/display/qpid/Java+Build+System
> TO DO
> - Fix what the systests/perftests do to copy the test-profiles dir to the necessary location.
> - Test deploying the modules to a local Nexus instance (by overriding the repo properties
locally).
> - Ensure we dont deploy modules we aren't already doing so, it will make changing them
later less of a pain for everyone.
> - Align the XML in the pom files consistently, fix whitepsace errors.
> - improve the performance hit from using the license plugin
> - check that perf-tests actually needs the unpacked broker for running non spawn profiles
and remove if not
> - remove the child module version to let them inherit from java parent
> - check the bcel bundle dependancy exclusions are still required
> === Once the Ant build is removed ===
> - Move all the resources to be in the /src/foo/resources folders.
> - Make qpidversion.properties in common be a filtered resource instead of generated.
> - Get rid of the antrun-plugin execution in common, directly invoke the required java
elements.
> - Do the above in the generate-sources-common profile instead of current default config.
> - Get rid of the antrun-plugin execution in broker-core, directly invoke the required
java elements.
> - Fix the tests not to be dependant on the working dir being the java dir.
> - Fix the tests not to be dependant on the test config/output dirs being children of
qpid.home.
> - Remove the QBTC output file mechanics, rely on Surefire to do it?
> - JUnit test profiles instead of Exludes files?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message