qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-5653) [Java Broker] Make message and configuration store stateless
Date Fri, 04 Apr 2014 10:22:15 GMT

    [ https://issues.apache.org/jira/browse/QPID-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959846#comment-13959846
] 

ASF subversion and git services commented on QPID-5653:
-------------------------------------------------------

Commit 1584600 from kwall@apache.org in branch 'qpid/trunk'
[ https://svn.apache.org/r1584600 ]

QPID-5653: Replace DurableConfigurationStore/MessageStore recoverers with visitors.

* MS/DCS impls now have stateless visitXXX methods to retrieve message/configuration data
(replaces the recoverXXXX methods)
* VH implementations now uses Handlers to perform the recovery operation.
* DCS's handler (ConfiguredObjectRecordRecoveverAndUpgrader) currently implemented in terms
of the old DefaultUpgradeProvider/DurableConfigurationRecoverer.
  This will be refactored by a future commit.

> [Java Broker] Make message and configuration store stateless
> ------------------------------------------------------------
>
>                 Key: QPID-5653
>                 URL: https://issues.apache.org/jira/browse/QPID-5653
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: 0.29
>
>
> The MessageStore (and DurableConfigurationStore) implementations are currently stateful.
They own the recovery process and have special rules around some states (in some states updates
are ignored).  This is overly complicated.  Currently all store implementations need to code
these rules. This is poor division of responsibilities and this presents a barrier to users
wishing to produce their own store implementations.
> This change will simplify the responsibilities of the store:
> * introduce simpler lifecycle methods i.e. open/close
> * simpler state concept, the store is either open or not
> * visit methods for retrieving data from the store.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message