qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-5709) [Java Broker] Remove ExchangeFactory/ExchangeRegistry and use common replacement mechanism for recovery/construction of exchanges
Date Tue, 22 Apr 2014 22:26:15 GMT

    [ https://issues.apache.org/jira/browse/QPID-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977556#comment-13977556
] 

Keith Wall commented on QPID-5709:
----------------------------------

Hi Rob

I have reviewed commit r1588126.  A couple of comments.

# New method DirectExchange.BindingSet#updateBinding has an unused argument.
# TopicExchange#onBindingUpdated - debug message incorrect
# TopicExchange# method level synchronised used inconsistently to guard _bindings. The _binding
map check then get (line 95) could lead to unexpected results.

Separately, I notice that:

# DefaultQueueRegistry and interface QueueRegistry is now dead code


> [Java Broker] Remove ExchangeFactory/ExchangeRegistry and use common replacement mechanism
for recovery/construction of exchanges
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-5709
>                 URL: https://issues.apache.org/jira/browse/QPID-5709
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>
> The virtualhost itself should act as the registry for its children.  Exchange factories
should be replaced by the new mechanism which is common to all configured objects



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message