qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-5709) [Java Broker] Remove ExchangeFactory/ExchangeRegistry and use common replacement mechanism for recovery/construction of exchanges
Date Thu, 24 Apr 2014 11:41:16 GMT

    [ https://issues.apache.org/jira/browse/QPID-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979602#comment-13979602
] 

Keith Wall commented on QPID-5709:
----------------------------------

Also:

# AbstractConfiguredObject#registerChild  - extract method and/or add a comment to better
explain the intent of duplicate child name algorithm.
# I wonder if Model.getCategory() should throw an IAE (with good error message including the
clazz's name) if clazz cannot be resolved into a category name.  I think diagnosing a problem
from the NPE within getCategory's trying to infer what the argument might have been from the
stack might be hard.
# In AbstractConfiguredObject's constructor the null check guarding null from getAttributeNames
is now superfluous.  
# AbstractConfiguredObject#getParent synchronisation is unnecessary as parent are now only
set on construction.




> [Java Broker] Remove ExchangeFactory/ExchangeRegistry and use common replacement mechanism
for recovery/construction of exchanges
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-5709
>                 URL: https://issues.apache.org/jira/browse/QPID-5709
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>
> The virtualhost itself should act as the registry for its children.  Exchange factories
should be replaced by the new mechanism which is common to all configured objects



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message