qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec" <pmora...@redhat.com>
Subject Re: Review Request 21234: QPID-5747: ensure that outgoing connection failure is communicated to upper level
Date Mon, 12 May 2014 07:59:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21234/#review42674
-----------------------------------------------------------

Ship it!


The code change makes sense to me, though I am not too much familiar with AsynchIOHandler.

I run few tests relevant to original JIRA and everytime the link was attempting to reconnect
as expected.

>From my side, ship it.

- Pavel Moravec


On May 8, 2014, 8:04 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21234/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 8:04 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Pavel Moravec.
> 
> 
> Bugs: QPID-5747
>     https://issues.apache.org/jira/browse/QPID-5747
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The failed callback passed in to Broker::connect() is only used until the TCP connection
is established. The codec (i.e. qpid::broker::Connection object) is only created the first
time the connection is writable. If the connection fails between establishing the tcp connection
and determining that it is writable, then there is no way to communicate the failure.
> 
> This option fixes that by creating the codec object on disconnect if it hasn't already
been created (and the connection is an outgoing one).
> 
> (Another option I think would be to create the codec for outgoing connections on AsyncHandler::init(),
and add another flag to track whether the protocol header had been sent.)
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1593267 
> 
> Diff: https://reviews.apache.org/r/21234/diff/
> 
> 
> Testing
> -------
> 
> make test passes; original issue doesn't reproduce
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message