qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 21925: QPID-5773: revert non-essential recv path change from QPID-4872
Date Tue, 27 May 2014 13:20:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21925/
-----------------------------------------------------------

(Updated May 27, 2014, 1:20 p.m.)


Review request for qpid and Justin Ross.


Changes
-------

reloading original patch - reviewboard isn't making it available.


Bugs: qpid-5773
    https://issues.apache.org/jira/browse/qpid-5773


Repository: qpid


Description
-------

For bug QPID-4872, I modified both the receive path and the send path in the transport code.
 Turns out only the send path is necessary - the original bug will not present on the receive
path (checked the python code and openssl sources to confirm).  The change to the receive
path is actually less efficient as some versions of python merely implement recv_into by allocating
a temp buffer and calling recv then doing a copy into the passed buffer!

This change reverts the recv side of QPID-4872. 


Diffs (updated)
-----

  /trunk/qpid/python/qpid/messaging/transports.py 1597595 

Diff: https://reviews.apache.org/r/21925/diff/


Testing
-------

SSL unit tests.


Thanks,

Kenneth Giusti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message