qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request 21978: QPID-5788: lazy initialisation of NSS
Date Wed, 28 May 2014 19:51:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21978/
-----------------------------------------------------------

(Updated May 28, 2014, 7:51 p.m.)


Review request for qpid and Andrew Stitcher.


Changes
-------

Moved lazy initialisation logic into static member function and rearranged the exception handling/throwing
as requested. (The lock and initialised flag are not static member variables as I don't want
them to be shared when forking).


Bugs: QPID-5788
    https://issues.apache.org/jira/browse/QPID-5788


Repository: qpid


Description
-------

Delay initialisation of NSS until the first SSL connection is created. This allows env vars
to be set programmatically if desired and allows forking (provided connections are created
*after* forking).


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1597730 

Diff: https://reviews.apache.org/r/21978/diff/


Testing
-------

make test passes

The two test cases described in the JIRA work as expected


Thanks,

Gordon Sim


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message