qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 22024: QPID-5790: avoid use of poll if greenthreads has monkey-patched select
Date Fri, 30 May 2014 12:47:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22024/
-----------------------------------------------------------

(Updated May 30, 2014, 12:47 p.m.)


Review request for qpid, Gordon Sim, Rafael Schloming, and Ted Ross.


Bugs: qpid-5790
    https://issues.apache.org/jira/browse/qpid-5790


Repository: qpid


Description
-------

Modify the python client to use select.select() instead of select.poll() if the application
has been monkey-patched by Eventlet/Greenthreads.

Eventlet only properly patches select.select(), not select.poll().  If select.poll() is used,
the application may hang.  This patch detects if the application is using a patched select,
and uses that instead of poll.


Diffs
-----

  /trunk/qpid/python/qpid/compat.py 1598260 

Diff: https://reviews.apache.org/r/22024/diff/


Testing
-------

Tested the python client:

1) running it in an environment that did not have eventlet installed - poll used
2) eventlet was installed, but select was not patched - poll used
3) select was patched - patched select was used.


Thanks,

Kenneth Giusti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message