qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Created] (QPID-5738) [Java Broker] AbstractConfigureObject#setAttribute() does not validate attributes
Date Thu, 01 May 2014 06:07:14 GMT
Keith Wall created QPID-5738:
--------------------------------

             Summary: [Java Broker] AbstractConfigureObject#setAttribute() does not validate
attributes
                 Key: QPID-5738
                 URL: https://issues.apache.org/jira/browse/QPID-5738
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
            Reporter: Keith Wall
            Assignee: Rob Godfrey
             Fix For: 0.29
         Attachments: setAttributeRefactor.patch

Code path ACO#setAttribute omits to invoke the attribute validation facilities of ACO.   This
means that there are circumstances (mainly via the JMX interface) where an unvalidated attribute
value can be set on a configured object.

We decided that in the short term, ACO#setAttribute() should delegate to its pluralised version
(which does validate attributes).    We tried, I found a couple of tests fell foul of the
validations and needed remediated.  The problem also highlighted AbstractQueue's exclusive
attribute, whose validations appears to need need some work to conform to the new model.

WIP patch attached.

 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message